Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target latest stable Rust version in CI script #275

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Target latest stable Rust version in CI script #275

merged 1 commit into from
Nov 14, 2022

Conversation

GuillaumeGomez
Copy link
Contributor

It should help with #272.

If you prefer (and if you're interested at all in this PR), I can target instead a specific Rust version instead of the latest stable.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 13, 2022
Merged
@Shatur
Copy link
Contributor

Shatur commented Nov 14, 2022

I would suggest to use https://github.com/dtolnay/rust-toolchain because actions-rs are deprecated.
Bevy do the same, see bevyengine/bevy#6432.

@GuillaumeGomez
Copy link
Contributor Author

actions-rs doesn't seem to be deprecated: https://github.com/actions-rs/toolchain ? I find it much easier to read and maintain than https://github.com/dtolnay/rust-toolchain (personal point of view).

@Shatur
Copy link
Contributor

Shatur commented Nov 14, 2022

actions-rs doesn't seem to be deprecated: https://github.com/actions-rs/toolchain

It was updated two years ago and the author doesn't answer to any PR or issue.
See the PR in Bevy I linked above.

I find it much easier to read and maintain

What do you mean? Its basically a few lines of code in CI config.

@GuillaumeGomez
Copy link
Contributor Author

GuillaumeGomez commented Nov 14, 2022 •
edited
Loading

Sorry, I badly read the docs. It seems to be more or less the same syntax-wise so I switched to it.

@sebcrozet sebcrozet merged commit 4bb0e82 into dimforge:master Nov 14, 2022
@sebcrozet
Copy link
Member

Thanks!

@GuillaumeGomez GuillaumeGomez deleted the patch-1 branch November 14, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shatur Shatur Shatur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGomez @Shatur @sebcrozet